First version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from Altair into sphinxext_altair/altairplot.py
…hich does not exist
…/research. Add sphinx extension classifier as recommended in sphinx docs. Change environment to Plugins. Add typed classifier
mattijn
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See vega/altair#3051 for context.
For the review:
altairplot.py: I copied it over from Altair in the first commit and added some type hints and did smaller docstring improvements in subsequent commits. I therefore think this does not require a detailed review.tests: Tests are inspired by some other sphinx extensions and by the sphinx repo itself which uses the same folder structure and approach to test directives.The
README.mdhas some instructions on how this package can be manually tested if required by building the test documentation. Furthermore, I created a PR over in the altair repo vega/altair#3056 which uses the code from this branch to build the whole altair documentation. That worked well without any issues.Not sure why workflows are not yet executed, do they need to be merged first at least once? They are executed in my fork so you can view the status there: https://github.com/binste/sphinxext-altair/actions
Happy to do a release on pypi once this gets approved and add @mattijn and @joelostblom as maintainers as well. I can of course also add more if you want.