You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that for some charts, like the interactive_concat_layer Vega Lite example, on the initial load it re-renders the view unnecessarily.
The reason is that the componentDidUpdate for the renderer does a deep equality check and I noticed it is finding the previous vegaSpec different from the current one. However, the only difference between them is that some of the objects values are undefined, and the current library to do deep equality checking finds these as different (epoberezkin/fast-deep-equal#127). I assume that in this case, two vega specs are equal, even if some have keys map to undefined. If I serialize both specs to JSON, the JSON is equal.
The text was updated successfully, but these errors were encountered:
I noticed that for some charts, like the
interactive_concat_layer
Vega Lite example, on the initial load it re-renders the view unnecessarily.The reason is that the
componentDidUpdate
for the renderer does a deep equality check and I noticed it is finding the previousvegaSpec
different from the current one. However, the only difference between them is that some of the objects values are undefined, and the current library to do deep equality checking finds these as different (epoberezkin/fast-deep-equal#127). I assume that in this case, two vega specs are equal, even if some have keys map to undefined. If I serialize both specs to JSON, the JSON is equal.The text was updated successfully, but these errors were encountered: