Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate=False seemingly has no effect in to_dict() for encoding channel classes #3075

Open
joelostblom opened this issue Jun 1, 2023 · 1 comment
Labels

Comments

@joelostblom
Copy link
Contributor

While alt.Chart().to_dict(validate=False) bypasses validation as expected, it seems like the same is not true for the encoding classes. For example, alt.Color('test').to_dict(validate=False) raises ValueError: test encoding field is specified without a type

@joelostblom joelostblom added the bug label Jun 1, 2023
@binste
Copy link
Contributor

binste commented Jun 1, 2023

I agree that it's more intuitive if we don't raise the error if validate=False and so that it's a bug. One minor addition: validate=False still disables the jsonschema validation for channels but we don't even get that far as there is this ValueError which is raised already in FieldChannelMixin.to_dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants