Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_server source should be able to store all headers #18937

Open
sonnens opened this issue Oct 25, 2023 · 1 comment
Open

http_server source should be able to store all headers #18937

sonnens opened this issue Oct 25, 2023 · 1 comment
Labels
source: http_server Anything `http_server` source related type: feature A value-adding code addition that introduce new functionality.

Comments

@sonnens
Copy link
Contributor

sonnens commented Oct 25, 2023

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

the http_server source currently only stores a set of predefined headers, it should be able to store all incoming headers or a set of headers minus a defined redacted set

The specific use case for us that we encountered is that Github's webhook notifications store the event type (eg push, pull request, issue, etc) in the X-Github-Event header. Other services store other meaningful information in other headers, etc.

Attempted Solutions

we can try to pre-define all the headers we might encounter , but if we start consuming data from another http source that also stores meaningful information in the headers that information is lost until we 1) realize it and 2) update our vector config to store it in an ever-growing list of mostly null values

Proposal

with source namespacing , vector can choose to store all the headers (or all minus a redacted list) in a headers namespace metadata field & it can be processed further down the line or at the terminus sink.

I've opened a pull request that does this: #18922

References

No response

Version

No response

@sonnens sonnens added the type: feature A value-adding code addition that introduce new functionality. label Oct 25, 2023
@neuronull neuronull added the source: http_server Anything `http_server` source related label Oct 25, 2023
@erlangparasu
Copy link
Contributor

any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: http_server Anything `http_server` source related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants