Bump to Rust 1.73.0

[jszwedko]

https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html

[aanderse]

i built vector with rust version 1.73.0 and ran into this failure:

error: call to `.clone()` on a reference in this situation does nothing
   --> src/convert_config.rs:160:93
    |
160 |                       .unwrap_or_else(|| panic!("Failed to get file_name for {entry_path:?}"))
    |  _____________________________________________________________________________________________^
161 | |                     .clone();
    | |____________________________^ help: remove this redundant call
    |
    = note: the type `std::ffi::OsStr` does not implement `Clone`, so calling `clone` on `&std::ffi::OsStr` copies the reference, which does not do anything and can be removed
note: the lint level is defined here
   --> src/lib.rs:7:9
    |
7   | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(noop_method_call)]` implied by `#[deny(warnings)]`

error: could not compile `vector` (lib) due to previous error

i'm not a rust guy so i defer to the experts... could this issue be caused by a change in rust from 1.72 to 1.73?

any and all help is greatly appreciated 🙇‍♂️

[StephenWakely]

any and all help is greatly appreciated 🙇‍♂️

That is technically just a warning telling us that the call to clone the entry_path is unnecessary. It looks like the rust compiler got a little smarter and can now detect this.

This can be fixed by just removing the .clone() call.

                let last_component = entry_path
                    .file_name()
                    .unwrap_or_else(|| panic!("Failed to get file_name for {entry_path:?}"));
-                   .clone();

[dsmith3197]

#19518