Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(buffers): disk buffer should attempt to constrain file permissions when possible #18853

Closed
tobz opened this issue Oct 16, 2023 · 0 comments · Fixed by #18895
Closed

bug(buffers): disk buffer should attempt to constrain file permissions when possible #18853

tobz opened this issue Oct 16, 2023 · 0 comments · Fixed by #18895
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: security Anything related to security type: bug A code related bug.

Comments

@tobz
Copy link
Contributor

tobz commented Oct 16, 2023

Currently, disk buffers do not explicitly attempt to set permissions on the directories/files they create, instead relying solely on whatever the prevailing system configuration dictates (i.e. Linux's umask setting).

This means that, in some cases, disk buffer files are world readable. While we do provide an option for hardening Vector, in terms of default file permissions, this is opt-in... and we can generally do better than that.

We should attempt to at least mark disk buffer directories/files as readable/writable by the owner and group, but entirely inaccessible by others/world. Given that Vector itself is the only process that should be touching the files, it stands to reason that we should not allow world/others to ever read or write to those files.

@tobz tobz added domain: buffers Anything related to Vector's memory/disk buffers domain: security Anything related to security labels Oct 16, 2023
@neuronull neuronull added the type: bug A code related bug. label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: security Anything related to security type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants