Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ability to set a static concurrency for request.concurrency #18595

Open
jszwedko opened this issue Sep 18, 2023 · 2 comments · Fixed by #18651
Open

Document ability to set a static concurrency for request.concurrency #18595

jszwedko opened this issue Sep 18, 2023 · 2 comments · Fixed by #18651
Labels
domain: ARC Anything related to adaptive request concurrency domain: external docs Anything related to Vector's external, public documentation type: bug A code related bug.

Comments

@jszwedko
Copy link
Member

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

The documentation for request.concurrency doesn't indicate that you can set a static concurrency limit (a useful feature).

Screenshot 2023-09-18 at 8 43 08 AM

We should fix the docs to document how to set a static concurrency (like request.concurrency = 50).

Configuration

No response

Version

vector v0.32.1

Debug Output

No response

Example Data

No response

Additional Context

No response

References

@jszwedko jszwedko added type: bug A code related bug. domain: external docs Anything related to Vector's external, public documentation domain: ARC Anything related to adaptive request concurrency labels Sep 18, 2023
@jszwedko
Copy link
Member Author

I think this is still an issue as we the changes to document a static concurrency were backed out of #18651

@jszwedko jszwedko reopened this Sep 26, 2023
@neuronull
Copy link
Contributor

neuronull commented Oct 26, 2023

This seems to be related to how the docs are generated from the code, and the fact that the fixed concurrency isn't actually represented in the enum.

Perhaps a way forward is to add an example to showcase the static usage, which we don't have right now.

We can also see if the auto generation of docs could be improved to handle this use case.

pub enum Concurrency {
/// A fixed concurrency of 1.
///
/// Only one request can be outstanding at any given time.
None,
/// Concurrency is managed by the [Adaptive Request Concurrency][arc] feature.
///
/// [arc]: https://vector.dev/docs/about/under-the-hood/networking/arc/
Adaptive,
/// A fixed amount of concurrency is allowed.
Fixed(usize),
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ARC Anything related to adaptive request concurrency domain: external docs Anything related to Vector's external, public documentation type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants