Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing the iOS default silhoutte when the user/room avatar is missing #965

Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented May 26, 2023

IMG_0175
IMG_66D166C0BFB0-1

@Velin92 Velin92 requested a review from a team as a code owner May 26, 2023 15:14
@Velin92 Velin92 requested review from stefanceriu and removed request for a team May 26, 2023 15:14
@github-actions
Copy link

github-actions bot commented May 26, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6128c17

@Velin92 Velin92 requested a review from callumu May 26, 2023 15:15
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.55 ⚠️

Comparison is base (33e80b5) 47.64% compared to head (bf2b862) 47.09%.

❗ Current head bf2b862 differs from pull request most recent head 6128c17. Consider uploading reports for the commit 6128c17 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #965      +/-   ##
===========================================
- Coverage    47.64%   47.09%   -0.55%     
===========================================
  Files          343      343              
  Lines        21764    21824      +60     
  Branches     11902    11931      +29     
===========================================
- Hits         10369    10279      -90     
- Misses       11102    11255     +153     
+ Partials       293      290       -3     
Flag Coverage Δ
unittests 24.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 51.63% <0.00%> (ø)
...urces/Other/Extensions/UNNotificationContent.swift 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 force-pushed the mauroromito/default_ios_silhouttes_when_avatar_is_missing branch from 5e2a2b2 to c4ec525 Compare May 26, 2023 15:57
@Velin92 Velin92 enabled auto-merge (squash) May 26, 2023 15:57
@Velin92 Velin92 force-pushed the mauroromito/default_ios_silhouttes_when_avatar_is_missing branch from bf2b862 to 7f473b6 Compare May 29, 2023 08:18
@Velin92 Velin92 force-pushed the mauroromito/default_ios_silhouttes_when_avatar_is_missing branch from 7f473b6 to 6128c17 Compare May 29, 2023 08:26
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit ce6d686 into develop May 29, 2023
@Velin92 Velin92 deleted the mauroromito/default_ios_silhouttes_when_avatar_is_missing branch May 29, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants