Ignore background images in OnboardingBackgroundView for VoiceOver users [Bugfix]

[sempruijs]

Pull Request Checklist

• I read the contributing guide
• Pull request contains a changelog file in ./changelog.d
• Pull request includes a sign off

UI changes have been tested with:

• iPhone and iPad simulators in portrait and landscape orientations.
• Dark mode enabled and disabled.
• Various sizes of dynamic type.
• Voiceover enabled.

In the welcome screen when you boot the app for the first time, there are moving images that are not useful for VoiceOver users. This pr ignores them.

I do not know the flow of adding lines to the change log, so if someone could explain how that works, I would be glad :)
(It's my first time here)

[sempruijs]

Signed-off-by: Sem Pruijs [email protected]

[pixlwave]

Thanks for your contribution @sempruijs, this PR looks good to me. If you could update your changelog filename to be pr-658.bugfix, I'll get this merged.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sempruijs]

Yesss did it 🙌

[pixlwave]

Thanks very much @sempruijs, I'm sure VoiceOver users will appreciate this contribution 🙌

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (9ace5ac) 52.31% compared to head (09f7b4e) 52.31%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #658      +/-   ##
===========================================
- Coverage    52.31%   52.31%   -0.01%     
===========================================
  Files          259      259              
  Lines        14187    14188       +1     
  Branches      9118     9118              
===========================================
  Hits          7422     7422              
- Misses        6543     6544       +1     
  Partials       222      222              

Flag	Coverage Δ
unittests	20.82% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...reens/OnboardingScreen/View/OnboardingScreen.swift	43.24% <0.00%> (-0.30%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pannie]

LGTM