Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftFormat wraparguments rule. #579

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Add SwiftFormat wraparguments rule. #579

merged 2 commits into from
Feb 15, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 14, 2023

Matches the wrapparameters rule, seems it was missed and left an inconsistency between func and init styles.

Maybe controversial, I've disabled formatting on the Package manifests.

Matches the wrapparameters rule, seems it was missed.
@github-actions
Copy link

github-actions bot commented Feb 14, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against eee739b

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 49.08% // Head: 39.97% // Decreases project coverage by -9.11% ⚠️

Coverage data is based on head (6a1cb88) compared to base (96363b1).
Patch coverage: 68.75% of modified lines in pull request are covered.

❗ Current head 6a1cb88 differs from pull request most recent head eee739b. Consider uploading reports for the commit eee739b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #579      +/-   ##
===========================================
- Coverage    49.08%   39.97%   -9.11%     
===========================================
  Files          256      301      +45     
  Lines        14922    17375    +2453     
  Branches      9904    11470    +1566     
===========================================
- Hits          7324     6946     -378     
- Misses        7318    10111    +2793     
- Partials       280      318      +38     
Flag Coverage Δ
unittests 21.09% <68.75%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Other/BlurHashDecode.swift 0.00% <0.00%> (ø)
.../Sources/Services/Authentication/OIDCService.swift 0.00% <0.00%> (ø)
ElementX/Sources/Other/UserAgentBuilder.swift 100.00% <100.00%> (ø)
...s/Other/SwiftUI/Views/FormSectionHeaderStyle.swift 0.00% <0.00%> (-100.00%) ⬇️
...ther/SwiftUI/Views/SettingsActionButtonStyle.swift 0.00% <0.00%> (-100.00%) ⬇️
...urces/Other/SwiftUI/Views/SettingsDefaultRow.swift 0.00% <0.00%> (-96.00%) ⬇️
...ources/Other/SwiftUI/Views/SettingsPickerRow.swift 0.00% <0.00%> (-94.74%) ⬇️
...s/Timeline/Fixtures/RoomTimelineItemFixtures.swift 0.00% <0.00%> (-80.49%) ⬇️
...s/Screens/RoomDetails/View/RoomDetailsScreen.swift 0.00% <0.00%> (-80.37%) ⬇️
...rces/Other/SwiftUI/Animation/ShimmerModifier.swift 0.00% <0.00%> (-74.29%) ⬇️
... and 161 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pixlwave pixlwave enabled auto-merge (squash) February 15, 2023 08:38
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit afc660a into develop Feb 15, 2023
@pixlwave pixlwave deleted the doug/swiftformat branch February 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants