Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tweaks #381

Merged
merged 13 commits into from
Dec 21, 2022
Merged

Various tweaks #381

merged 13 commits into from
Dec 21, 2022

Conversation

stefanceriu
Copy link
Member

  • moved the message delivery status outside of the main content and added it to the plain timeline as well
  • fixed glithcy scroll to bottom timeline button
  • simplified the emoji picker, double tapping a timeline item directly opens it now and added a context menu option. Linked it to rust side reaction sending
  • fixed cold cache seemingly not working (invalid rooms treated as empty)
  • made splash screen full screen
  • fixed connectivity indicator starting off as offline
  • added presentation detents on the NavigationStackCoordinator as they're not inherited from the child
  • fixed timeline item link tint colors
  • removed some unnecessary classes

@github-actions
Copy link

github-actions bot commented Dec 21, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b5c83e4

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 42.81% // Head: 41.89% // Decreases project coverage by -0.92% ⚠️

Coverage data is based on head (b5c83e4) compared to base (5b9d45e).
Patch coverage: 17.24% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
- Coverage    42.81%   41.89%   -0.93%     
===========================================
  Files          247      247              
  Lines        13878    14055     +177     
  Branches      7984     8176     +192     
===========================================
- Hits          5942     5888      -54     
- Misses        7737     7941     +204     
- Partials       199      226      +27     
Flag Coverage Δ
unittests 18.29% <1.40%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Sources/Screens/BugReport/BugReportViewModel.swift 36.95% <0.00%> (ø)
...ojiPickerScreen/EmojiPickerScreenCoordinator.swift 0.00% <0.00%> (ø)
...ns/EmojiPickerScreen/EmojiPickerScreenModels.swift 0.00% <ø> (ø)
...EmojiPickerScreen/EmojiPickerScreenViewModel.swift 0.00% <0.00%> (ø)
...ens/EmojiPickerScreen/View/EmojiPickerScreen.swift 0.00% <0.00%> (ø)
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 14.78% <0.00%> (-1.11%) ⬇️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 46.66% <ø> (-7.18%) ⬇️
...creen/View/Style/TimelineItemPlainStylerView.swift 0.00% <0.00%> (ø)
...eens/RoomScreen/View/TimelineItemContextMenu.swift 0.00% <0.00%> (ø)
.../RoomScreen/View/TimelineTableViewController.swift 0.00% <0.00%> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu merged commit 71f1f04 into develop Dec 21, 2022
@stefanceriu stefanceriu deleted the stefan/timelineTweaks branch December 21, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants