Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Receipts sheet + enabled RR by default #2123

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 20, 2023

Added a sheet that displays read receipts of that message in more detal when they are tapped
fixes #1053

Also enabled the FF for Read Receipts as true by default. If no problems are detected anymore we can safely then remove this FF once and for all.

@Velin92 Velin92 requested a review from a team as a code owner November 20, 2023 17:37
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 20, 2023 17:37
Copy link

github-actions bot commented Nov 20, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 23463b6

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (053e134) 71.91% compared to head (bf0ba79) 71.91%.

❗ Current head bf0ba79 differs from pull request most recent head 23463b6. Consider uploading reports for the commit 23463b6 to get more accurate results

Files Patch % Lines
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 25.00% 3 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 80.00% 2 Missing ⚠️
.../View/Supplementary/TimelineReadReceiptsView.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2123      +/-   ##
===========================================
- Coverage    71.91%   71.91%   -0.01%     
===========================================
  Files          509      511       +2     
  Lines        34597    34716     +119     
  Branches     16640    16671      +31     
===========================================
+ Hits         24882    24965      +83     
- Misses        9099     9137      +38     
+ Partials       616      614       -2     
Flag Coverage Δ
unittests 57.33% <94.26%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please can we fix the grouping too before enabling the feature flag though?

@Velin92 Velin92 enabled auto-merge (squash) November 21, 2023 11:12
@Velin92
Copy link
Member Author

Velin92 commented Nov 21, 2023

LGTM.

Please can we fix the grouping too before enabling the feature flag though?

@amshakal Are we okay in removing the grouping when a message has RRs?

EDIT:
Synced on matrix about this, in the end we decided to keep the grouping because the RRs might change so often that the grouping might make the messages group change constantly and that would probably be a bit overwhelming for the users.

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 7b812a4 into develop Nov 21, 2023
6 checks passed
@Velin92 Velin92 deleted the mauroromito/show_rr_sheet branch November 21, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapping on read receipts should display a sheet
3 participants