Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Compound List in more screens. #2099

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Use Compound List in more screens. #2099

merged 6 commits into from
Nov 17, 2023

Conversation

pixlwave
Copy link
Member

Adopts ListRow in the following screens:

Start Chat Room Member Details Notification Settings (minor tweak) Key Backup (minor tweak)
en-GB-iPhone-14 createRoom en-GB-iPhone-14 roomMemberDetails en-GB-iPhone-14 roomNotificationSettingsCustomSetting test_secureBackupScreen Recovery-incomplete

@pixlwave pixlwave requested a review from a team as a code owner November 16, 2023 17:47
@pixlwave pixlwave requested review from nimau and removed request for a team November 16, 2023 17:47
Copy link

github-actions bot commented Nov 16, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 763fe6d

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (2274262) 68.29% compared to head (e01374b) 68.25%.
Report is 2 commits behind head on develop.

❗ Current head e01374b differs from pull request most recent head 763fe6d. Consider uploading reports for the commit 763fe6d to get more accurate results

Files Patch % Lines
...ces/Screens/CreateRoom/View/CreateRoomScreen.swift 62.85% 23 Missing and 3 partials ⚠️
...creen/SecureBackupRecoveryKeyScreenViewModel.swift 0.00% 5 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 81.81% 2 Missing ⚠️
.../Settings/SettingsScreen/View/SettingsScreen.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2099      +/-   ##
===========================================
- Coverage    68.29%   68.25%   -0.05%     
===========================================
  Files          522      522              
  Lines        36417    36389      -28     
  Branches     17606    17594      -12     
===========================================
- Hits         24871    24836      -35     
- Misses       10931    10938       +7     
  Partials       615      615              
Flag Coverage Δ
unittests 57.31% <62.76%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for the NotificationSettingsEditScreen and the .isWaiting but I presume it will be fixed in Compound)

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit f2b4525 into develop Nov 17, 2023
6 checks passed
@pixlwave pixlwave deleted the doug/compound-list branch November 17, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants