-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Compound List in more screens. #2099
Conversation
Generated by 🚫 Danger Swift against 763fe6d |
UnitTests/__Snapshots__/PreviewTests/test_notificationSettingsEditScreen.Applying-change.png
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2099 +/- ##
===========================================
- Coverage 68.29% 68.25% -0.05%
===========================================
Files 522 522
Lines 36417 36389 -28
Branches 17606 17594 -12
===========================================
- Hits 24871 24836 -35
- Misses 10931 10938 +7
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5188180
to
e01374b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except for the NotificationSettingsEditScreen
and the .isWaiting
but I presume it will be fixed in Compound
)
e01374b
to
763e4a4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Adopts ListRow in the following screens: