Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix presentation when not enrolled in Touch/Face ID. #1981

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

pixlwave
Copy link
Member

This PR makes a small tweak to the app lock setup state machine to differentiate between creating a PIN or updating a PIN.

@pixlwave pixlwave requested a review from a team as a code owner October 30, 2023 11:00
@pixlwave pixlwave requested review from alfogrillo and removed request for a team October 30, 2023 11:00
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 93bcb4d

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (5439b65) 69.32% compared to head (93bcb4d) 69.29%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1981      +/-   ##
===========================================
- Coverage    69.32%   69.29%   -0.03%     
===========================================
  Files          518      518              
  Lines        35657    35660       +3     
  Branches     17294    17297       +3     
===========================================
- Hits         24718    24712       -6     
- Misses       10283    10295      +12     
+ Partials       656      653       -3     
Flag Coverage Δ
unittests 54.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...FlowCoordinators/AppLockSetupFlowCoordinator.swift 30.41% <0.00%> (-3.10%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit 8f01053 into develop Oct 30, 2023
10 checks passed
@pixlwave pixlwave deleted the doug/app-lock-no-biometrics branch October 30, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants