Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizable Composer With Completion Suggestion View #1971

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Resizable Composer With Completion Suggestion View #1971

merged 8 commits into from
Oct 27, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 26, 2023 •
edited
Loading

fixes #1822
fixes #1858

@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0ec85a2

@Velin92 Velin92 marked this pull request as ready for review October 27, 2023 11:20
@Velin92 Velin92 requested a review from a team as a code owner October 27, 2023 11:20
@Velin92 Velin92 requested review from alfogrillo and removed request for a team October 27, 2023 11:20
@Velin92 Velin92 force-pushed the mauroromito/resizable_composer_with_suggestions_view branch from 8cd91e9 to 491d095 Compare October 27, 2023 13:05
@Velin92 Velin92 requested a review from pixlwave October 27, 2023 13:16
@Velin92 Velin92 force-pushed the mauroromito/resizable_composer_with_suggestions_view branch from 7287b13 to 5767b97 Compare October 27, 2023 13:16
pixlwave
pixlwave approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ElementX/Sources/Application/AppSettings.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/CompletionSuggestionView.swift Show resolved Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/CompletionSuggestionView.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/CompletionSuggestionView.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenModels.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 enabled auto-merge (squash) October 27, 2023 13:36
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 27, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@Velin92 Velin92 merged commit 0b31446 into develop Oct 27, 2023
6 checks passed
@Velin92 Velin92 deleted the mauroromito/resizable_composer_with_suggestions_view branch October 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@alfogrillo alfogrillo Awaiting requested review from alfogrillo alfogrillo is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mentions: Fix user suggestion view in expanded mode Mentions: Update user mentions to match final designs
2 participants
@Velin92 @pixlwave