Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DesignKit package #1886

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Remove DesignKit package #1886

merged 3 commits into from
Oct 12, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 12, 2023

This PR deletes the old DesignKit package and removes the use of the legacy element-design-tokens dependency.

  • The button styles are now part of Compound.
  • The text style has been moved to the Authentication module as that is its only use.
  • The brand colour has been added locally for now until it's included in Compound.

@pixlwave pixlwave requested a review from a team as a code owner October 12, 2023 10:59
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 12, 2023 10:59
- Move button styles to Compound
- Rename text style to AuthenticationTextStyle as its only in the auth flow.
- Add the brand colour locally for now until its included in Compound.
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 647724b

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey! 👏

Fix quote colour.
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6791a95) 70.93% compared to head (647724b) 70.92%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1886      +/-   ##
===========================================
- Coverage    70.93%   70.92%   -0.02%     
===========================================
  Files          461      462       +1     
  Lines        31197    31305     +108     
  Branches     15253    15283      +30     
===========================================
+ Hits         22131    22202      +71     
- Misses        8506     8536      +30     
- Partials       560      567       +7     
Flag Coverage Δ
unittests 54.74% <71.69%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ources/Other/SwiftUI/Layout/FullscreenDialog.swift 72.80% <100.00%> (ø)
...s/Other/SwiftUI/Views/PlaceholderAvatarImage.swift 98.18% <ø> (ø)
...yticsPromptScreen/View/AnalyticsPromptScreen.swift 98.66% <100.00%> (ø)
.../Authentication/LoginScreen/View/LoginScreen.swift 96.74% <100.00%> (ø)
...irmationScreen/View/ServerConfirmationScreen.swift 100.00% <100.00%> (ø)
...erSelectionScreen/View/ServerSelectionScreen.swift 97.40% <100.00%> (ø)
...ation/SoftLogoutScreen/View/SoftLogoutScreen.swift 90.60% <100.00%> (ø)
...ntication/WaitlistScreen/View/WaitlistScreen.swift 94.73% <100.00%> (ø)
...ces/Screens/CreateRoom/View/CreateRoomScreen.swift 85.50% <100.00%> (ø)
...Screens/InvitesScreen/View/InvitesScreenCell.swift 96.42% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 2c5662a into develop Oct 12, 2023
8 checks passed
@pixlwave pixlwave deleted the doug/compound-buttons branch October 12, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants