-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup ready for PIN/Biometric app lock. #1876
Conversation
Generated by 🚫 Danger Swift against 3f3be93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments but generally LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1876 +/- ##
===========================================
- Coverage 70.91% 70.44% -0.47%
===========================================
Files 452 460 +8
Lines 30864 31076 +212
Branches 15124 15210 +86
===========================================
+ Hits 21886 21893 +7
- Misses 8418 8628 +210
+ Partials 560 555 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, can't wait to start using that new overlayWindow
80b2fb1
to
3f3be93
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The PR lays the initial groundwork for adding PIN/biometric unlock to the app. It makes the following changes:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-11.at.10.08.40.mp4