Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup ready for PIN/Biometric app lock. #1876

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 11, 2023

The PR lays the initial groundwork for adding PIN/biometric unlock to the app. It makes the following changes:

  • Adds a WindowManager which can switch between the main window and an alternate window.
    • Additionally includes an overlay window on the main window which we can use for global user indicators in the future.
  • Adds a AppLockFlowCoordinator and placeholder AppLockScreen.
  • Displays this flow in the alternate window when the app is backgrounded (placeholder view) and foregrounded (app lock screen).
  • Adds a feature flag for the flow.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-11.at.10.08.40.mp4

@pixlwave pixlwave requested a review from a team as a code owner October 11, 2023 09:26
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 11, 2023 09:26
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Services/UserSession/UserSessionStore.swift#L111 - FIXMEs should be resolved (Quick and dirty fix for stoppi...). (todo)

Generated by 🚫 Danger Swift against 3f3be93

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments but generally LGTM

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (b35bee5) 70.91% compared to head (3f3be93) 70.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1876      +/-   ##
===========================================
- Coverage    70.91%   70.44%   -0.47%     
===========================================
  Files          452      460       +8     
  Lines        30864    31076     +212     
  Branches     15124    15210      +86     
===========================================
+ Hits         21886    21893       +7     
- Misses        8418     8628     +210     
+ Partials       560      555       -5     
Flag Coverage Δ
unittests 54.48% <21.87%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Application/AppDelegate.swift 82.35% <100.00%> (+9.62%) ⬆️
ElementX/Sources/Application/AppSettings.swift 95.23% <ø> (ø)
...ication/Navigation/NavigationRootCoordinator.swift 54.32% <100.00%> (+3.00%) ⬆️
...es/Screens/AppLockScreen/AppLockScreenModels.swift 100.00% <100.00%> (ø)
...erOptionsScreen/DeveloperOptionsScreenModels.swift 0.00% <ø> (ø)
...ources/Services/UserSession/UserSessionStore.swift 47.10% <0.00%> (-2.08%) ⬇️
ElementX/Sources/Application/Application.swift 45.61% <0.00%> (-3.48%) ⬇️
.../Sources/Application/Windowing/SceneDelegate.swift 25.00% <25.00%> (ø)
...Screens/AppLockScreen/AppLockScreenViewModel.swift 81.81% <81.81%> (ø)
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% <0.00%> (ø)
... and 6 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, can't wait to start using that new overlayWindow

@pixlwave pixlwave enabled auto-merge (squash) October 11, 2023 12:05
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit b6470c9 into develop Oct 11, 2023
9 checks passed
@pixlwave pixlwave deleted the doug/pin-code-groundwork branch October 11, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants