Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request all required OIDC scopes + grant_types #154

Merged
merged 6 commits into from
Aug 11, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented Aug 2, 2022

No description provided.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Hugh. Would you mind adding a changelog file in ./changelog.d though please?

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hughns
Copy link
Member Author

hughns commented Aug 11, 2022

I've added changelog and also changed to use the new unstable scope names.

@hughns hughns requested a review from pixlwave August 11, 2022 10:26
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@codecov-commenter
Copy link

Codecov Report

Merging #154 (456b4a2) into develop (4349b8f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    35.01%   35.01%           
========================================
  Files          168      168           
  Lines        11739    11739           
  Branches      5747     5747           
========================================
  Hits          4110     4110           
  Misses        7537     7537           
  Partials        92       92           
Impacted Files Coverage Δ
...es/Authentication/AuthenticationServiceProxy.swift 0.00% <0.00%> (ø)
.../Sources/Services/Authentication/OIDCService.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pixlwave pixlwave merged commit 207cbde into element-hq:develop Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants