Fix a bug when dismissing a media preview. #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
requested review from
alfogrillo and
stefanceriu
and removed request for
a team and
alfogrillo
Generated by 🚫 Danger Swift against cacd749 |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1428 +/- ##
========================================
Coverage 54.12% 54.13%
========================================
Files 393 393
Lines 25709 25710 +1
Branches 13022 13022
========================================
+ Hits 13915 13918 +3
+ Misses 11419 11417 -2
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you tap on a media item when the keyboard is visible, dismissing the item sometimes returns you to a view where the composer is pushed up by a big white empty space where the keyboard would normally be. This PR makes sure the composer resigns focus before displaying the preview.