Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the timeline padding. #1233

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Update the timeline padding. #1233

merged 7 commits into from
Jul 4, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 4, 2023

This PR reduces the padding of bubbles to the edge of the screen when the avatar isn't shown (outgoing messages and DMs).

Additionally fixes other broken screenshots too.

DM:
Simulator Screenshot - iPhone 14 - 2023-07-04 at 10 49 20

Before/After from the screenshot tests:
Screenshot 2023-07-04 at 10 47 51 am

@pixlwave pixlwave requested a review from a team as a code owner July 4, 2023 09:45
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 4, 2023 09:45
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 476638e

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 3.17% and project coverage change: -0.06 ⚠️

Comparison is base (4162036) 40.84% compared to head (476638e) 40.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1233      +/-   ##
===========================================
- Coverage    40.84%   40.79%   -0.06%     
===========================================
  Files          418      419       +1     
  Lines        26643    26678      +35     
  Branches     13746    13759      +13     
===========================================
  Hits         10883    10883              
- Misses       15468    15503      +35     
  Partials       292      292              
Flag Coverage Δ
unittests 23.03% <3.17%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 43.36% <0.00%> (-0.33%) ⬇️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 46.00% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 51.42% <ø> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 42.13% <0.00%> (ø)
...ns/RoomScreen/View/Replies/TimelineReplyView.swift 0.00% <0.00%> (ø)
...een/View/Style/TimelineItemBubbledStylerView.swift 21.69% <0.00%> (-0.46%) ⬇️
...creen/View/Timeline/LocationRoomTimelineView.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Room/RoomProxyProtocol.swift 56.00% <ø> (ø)
...ne/TimelineController/RoomTimelineController.swift 0.00% <0.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@callumu
Copy link

callumu commented Jul 4, 2023

This looks good 👍

@pixlwave pixlwave merged commit eba3e5d into develop Jul 4, 2023
@pixlwave pixlwave deleted the doug/timeline-padding branch July 4, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants