Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp for media messages #1057

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 8, 2023

Simulator Screenshot - iPhone 14 - 2023-06-08 at 18 17 21

@Velin92 Velin92 requested a review from a team as a code owner June 8, 2023 16:18
@Velin92 Velin92 requested review from stefanceriu and callumu and removed request for a team June 8, 2023 16:18
@Velin92 Velin92 force-pushed the mauroromito/timestamp_for_non_bubbled_messages branch from da1094b to 5c6d2a0 Compare June 8, 2023 16:20
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f3f39c0

@Velin92 Velin92 linked an issue Jun 8, 2023 that may be closed by this pull request
6 tasks
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (4de6d07) 44.98% compared to head (f3f39c0) 44.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1057      +/-   ##
===========================================
- Coverage    44.98%   44.95%   -0.03%     
===========================================
  Files          371      371              
  Lines        23935    23945      +10     
  Branches     12737    12741       +4     
===========================================
- Hits         10766    10765       -1     
- Misses       12873    12885      +12     
+ Partials       296      295       -1     
Flag Coverage Δ
unittests 23.77% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...een/View/Style/TimelineItemBubbledStylerView.swift 31.93% <0.00%> (-1.53%) ⬇️
...omScreen/View/Timeline/ImageRoomTimelineView.swift 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 merged commit 361ac37 into develop Jun 8, 2023
@Velin92 Velin92 deleted the mauroromito/timestamp_for_non_bubbled_messages branch June 8, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story] Timestamp for messages
2 participants