Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved bug report error handling #1018

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Improved bug report error handling #1018

merged 3 commits into from
Jun 6, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 5, 2023 •
edited
Loading

This PR improves bug report uploading by

  • Checking for a 200 response before decoding the response body.
  • Showing the error from the server if the upload fails so its clearer what went wrong (as we can't get logs to find out)
  • Chunking the log files every 10MB (before compression).
  • Adding a max upload size and only adding files to the upload that don't exceed the limit.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 4d153df

@pixlwave pixlwave force-pushed the doug/bug-report-error-handling branch from 40a0da2 to f3ab7cd Compare June 5, 2023 16:19
@pixlwave pixlwave force-pushed the doug/bug-report-error-handling branch from f3ab7cd to 4d153df Compare June 5, 2023 16:26
@pixlwave pixlwave marked this pull request as ready for review June 5, 2023 16:26
@pixlwave pixlwave requested a review from a team as a code owner June 5, 2023 16:26
@pixlwave pixlwave requested review from stefanceriu and removed request for a team June 5, 2023 16:26
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

stefanceriu
stefanceriu approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@stefanceriu stefanceriu merged commit ea4aa94 into develop Jun 6, 2023
@stefanceriu stefanceriu deleted the doug/bug-report-error-handling branch June 6, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu