Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to FileCache logic. #444

Closed
pixlwave opened this issue Jan 11, 2023 · 1 comment · Fixed by #702
Closed

Improvements to FileCache logic. #444

pixlwave opened this issue Jan 11, 2023 · 1 comment · Fixed by #702
Assignees
Labels
T-Task T-User Story Team: Element X Platform X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@pixlwave
Copy link
Member

pixlwave commented Jan 11, 2023

Whenever we download media to show via AVPlayer/QuickLook the file is cached using naive guesses of the file extension. As we're writing Data to disk, the file doesn't have any useful type metadata, so if the file extension is wrong (e.g. #443) then playback/previewing will fail. We should either:

  • Add more robust file type detection by reading the mimetype from the event, and then checking the data received.
  • Pass this over to Rust itself and instead have it return us a valid URL to open the file from rather than data which we write to disk.
@pixlwave pixlwave added the Z-BBQ-Beta Required for ElementX - BBQ - Beta label Jan 11, 2023
@stefanceriu
Copy link
Member

Relates to #316

@stefanceriu stefanceriu added the X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue label Feb 16, 2023
@pixlwave pixlwave self-assigned this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task T-User Story Team: Element X Platform X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants