Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination stuck because of too many membership events #394

Closed
Tracked by #428
manuroe opened this issue Jan 2, 2023 · 0 comments · Fixed by #395
Closed
Tracked by #428

Pagination stuck because of too many membership events #394

manuroe opened this issue Jan 2, 2023 · 0 comments · Fixed by #395

Comments

@manuroe
Copy link
Member

manuroe commented Jan 2, 2023

If a room contains too many events that we do not display like membership events, the pagination stops to work. Matrix HQ is a good example around Jan, 2nd.

The reason is that the pagination listener receives no diff updates during a pagination cycle in this case. The app stays in pagination in progress mode.

At the app level , we did not have a reliable way to know when a pagination cycle is complete. The FFI layer actually breaks the async workflow defined by the SDK where the Room.paginateBackwards() should return only after all the calls of TimelineListener onUpdate(). It is actually called before.

This SDK PR adds more information to PaginationOutcome to handle and fix this case.

@manuroe manuroe changed the title Pagination stuck because of membership events Pagination stuck because of too many membership events Jan 3, 2023
@manuroe manuroe added the Z-BBQ-Beta Required for ElementX - BBQ - Beta label Jan 3, 2023
@manuroe manuroe self-assigned this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants