iPad/Mac split app layout #317
Assignees
Labels
Z-BBQ-Beta
Required for ElementX - BBQ - Beta
Comments
stefanceriu
added a commit
that referenced
this issue
Dec 12, 2022
Rename navigation components: SplitScreenCoordinator -> NavigationSplitCoordinator, StackScreenCoordinator -> NavigationStackCoordinator and SingleScreenCoordinator -> NavigationRootCoordinator [0c16103] Tweak navigation logging [826c19c] Move the navigation dismissal callbacks to the NavigationModule, add SingleScreenCoordinator tests [b8830d9] Add tests [252ad11] Merge the StackScreenCoordinator and SplitScreenCoordinators into a single file and stop publicly exposing their internal workings. Add more documentation. [3767169] Cleanup navigation logging [5140618] Use the parent SplitScreenCoordinator to present embedded StackScreenCoordinator sheets [b94b04c] Retract the room "syncing" indicator when dismissing a room [1467b0a] Correctly move to the no room selected state when popping in compact layouts [10bf2ad] Allow nilling root coordinators, replace present/dismiss sheet with setSheetCoordinator(?) [3371678] Add single screen coordinator fade transition animation [3cbe65e] Prevent the timeline table view from being reused between different rooms [9c94c50] Move files around [c10b6bc] Adapt the user session state machine to the split layout [7115a31] Fix unit and UI tests [1ece59e] Fix login flows [6884dc3] Use modules everywhere the underlying object is a NavigationModule [ab08d44] Rename navigation components to: SingleScreenCoordinator, SplitScreenCoordinator and StackScreenCoordinator [ada2be5] Add SplitNavigationController
stefanceriu
added a commit
that referenced
this issue
Dec 12, 2022
Rename navigation components: SplitScreenCoordinator -> NavigationSplitCoordinator, StackScreenCoordinator -> NavigationStackCoordinator and SingleScreenCoordinator -> NavigationRootCoordinator [0c16103] Tweak navigation logging [826c19c] Move the navigation dismissal callbacks to the NavigationModule, add SingleScreenCoordinator tests [b8830d9] Add tests [252ad11] Merge the StackScreenCoordinator and SplitScreenCoordinators into a single file and stop publicly exposing their internal workings. Add more documentation. [3767169] Cleanup navigation logging [5140618] Use the parent SplitScreenCoordinator to present embedded StackScreenCoordinator sheets [b94b04c] Retract the room "syncing" indicator when dismissing a room [1467b0a] Correctly move to the no room selected state when popping in compact layouts [10bf2ad] Allow nilling root coordinators, replace present/dismiss sheet with setSheetCoordinator(?) [3371678] Add single screen coordinator fade transition animation [3cbe65e] Prevent the timeline table view from being reused between different rooms [9c94c50] Move files around [c10b6bc] Adapt the user session state machine to the split layout [7115a31] Fix unit and UI tests [1ece59e] Fix login flows [6884dc3] Use modules everywhere the underlying object is a NavigationModule [ab08d44] Rename navigation components to: SingleScreenCoordinator, SplitScreenCoordinator and StackScreenCoordinator [ada2be5] Add SplitNavigationController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the new SwiftUI based navigation stack in place we should now also implement a custom split layout for iPads and macOS
The text was updated successfully, but these errors were encountered: