Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Element Call FF by default. #1983

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave requested a review from a team as a code owner October 30, 2023 12:23
@pixlwave pixlwave requested review from nimau and removed request for a team October 30, 2023 12:23
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 3c3b7fc

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Aligns with the same change on Android.
- Remove the now unused FF for mention pills.
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9cdc76) 69.20% compared to head (3c3b7fc) 69.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1983      +/-   ##
===========================================
+ Coverage    69.20%   69.23%   +0.03%     
===========================================
  Files          518      518              
  Lines        35708    35708              
  Branches     17318    17318              
===========================================
+ Hits         24712    24723      +11     
+ Misses       10347    10333      -14     
- Partials       649      652       +3     
Flag Coverage Δ
unittests 54.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.82% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit f63771d into develop Oct 30, 2023
10 checks passed
@pixlwave pixlwave deleted the doug/enable-element-call branch October 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants