Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions: @room mention pill #1829

Closed
Tracked by #2066
Velin92 opened this issue Sep 28, 2023 · 1 comment · Fixed by #1834
Closed
Tracked by #2066

Mentions: @room mention pill #1829

Velin92 opened this issue Sep 28, 2023 · 1 comment · Fixed by #1834
Assignees
@Velin92
Labels
A-Pills T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@Velin92
Copy link
Member

Velin92 commented Sep 28, 2023 •
edited
Loading

This is a special case, but the string @room should be interpreted as a special mention case and display a pill with probably its own different design.
Also it should display the room avatar
It does not need to have any tapping or link behaviour however
@Velin92 Velin92 added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Pills labels Sep 28, 2023
@Velin92 Velin92 self-assigned this Sep 28, 2023
@Velin92 Velin92 mentioned this issue Sep 28, 2023
Closed
@Velin92
Copy link
Member Author

Velin92 commented Sep 28, 2023

Kamino cloned this issue to vector-im/element-x-android

@Velin92 Velin92 mentioned this issue Sep 28, 2023
Closed
3 tasks
@Velin92 Velin92 linked a pull request Sep 29, 2023 that will close this issue
@room pill #1834
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velin92 Velin92

Labels
A-Pills T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@room pill element-hq/element-x-ios
1 participant
@Velin92