Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert MXLogger to Swift #166

Closed
pixlwave opened this issue Aug 30, 2022 · 0 comments · Fixed by #326
Closed

Convert MXLogger to Swift #166

pixlwave opened this issue Aug 30, 2022 · 0 comments · Fixed by #326
Assignees
@pixlwave
Labels
Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@pixlwave
Copy link
Member

MXLogger has been brought across wholesale from EI as an Objective-C class. Given that #102 is a no-go, we should re-write this class in Swift which would remove the need for the objc wrapper part of MXLog too.
@pixlwave pixlwave added the Z-BBQ-Alpha Required for ElementX - BBQ - Alpha label Aug 30, 2022
@pixlwave pixlwave self-assigned this Oct 18, 2022
@stefanceriu stefanceriu added the Z-BBQ-Beta Required for ElementX - BBQ - Beta label Oct 24, 2022
@pixlwave pixlwave mentioned this issue Nov 18, 2022
Merged
pixlwave added a commit that referenced this issue Nov 18, 2022
@pixlwave
#166: Re-write MXLogger in Swift
ba684d8 
* Add logging tests that cover file rotation.

* Re-write MXLogger in Swift.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixlwave pixlwave

Labels
Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-write MXLogger in Swift element-hq/element-x-ios
2 participants
@stefanceriu @pixlwave