Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send pin-drop location #1179

Merged
merged 12 commits into from
Jun 28, 2023
Merged

Send pin-drop location #1179

merged 12 commits into from
Jun 28, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented Jun 27, 2023

fixes #1116

Open send static location flow.
Just for a pin location without permissions or user's current location.
The location is sended in RoomFlowCoordinator.

@flescio flescio linked an issue Jun 27, 2023 that may be closed by this pull request
@flescio flescio changed the title Flescio/send static location Send pin-drop location Jun 27, 2023
@flescio flescio force-pushed the flescio/send_static_location branch from 0180bf7 to 21c7763 Compare June 27, 2023 12:26
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L405 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

⚠️

ElementX/Sources/Services/Timeline/GeoURI.swift#L70 - SwiftLint rule 'large_tuple' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

⚠️

ElementX/Sources/Services/Timeline/GeoURI.swift#L73 - There should be no space before and one after any comma. (comma)

Generated by 🚫 Danger Swift against 8eecd40

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 34.65% and project coverage change: -0.24 ⚠️

Comparison is base (b4cd58b) 41.95% compared to head (e804fd4) 41.71%.

❗ Current head e804fd4 differs from pull request most recent head 8eecd40. Consider uploading reports for the commit 8eecd40 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1179      +/-   ##
===========================================
- Coverage    41.95%   41.71%   -0.24%     
===========================================
  Files          403      407       +4     
  Lines        25522    25954     +432     
  Branches     13305    13448     +143     
===========================================
+ Hits         10708    10827     +119     
- Misses       14518    14834     +316     
+ Partials       296      293       -3     
Flag Coverage Δ
unittests 23.61% <34.65%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 46.11% <0.00%> (-1.99%) ⬇️
ElementX/Sources/Application/AppSettings.swift 96.66% <ø> (ø)
.../FlowCoordinators/UserSessionFlowCoordinator.swift 35.40% <0.00%> (-0.63%) ⬇️
...es/Other/Analytics/ScreenTrackerViewModifier.swift 88.88% <0.00%> (-11.12%) ⬇️
...urces/Other/Extensions/UNNotificationContent.swift 0.00% <ø> (ø)
...mentX/Sources/Other/MapLibre/MapLibreMapView.swift 0.00% <0.00%> (ø)
...rces/Other/SwiftUI/Animation/ShimmerModifier.swift 75.00% <ø> (ø)
...urces/Other/SwiftUI/Views/LocationMarkerView.swift 0.00% <0.00%> (ø)
...rces/Other/SwiftUI/Views/MatrixUserShareLink.swift 58.82% <0.00%> (-9.93%) ⬇️
...romptScreen/AnalyticsPromptScreenCoordinator.swift 65.21% <0.00%> (-16.61%) ⬇️
... and 82 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flescio flescio marked this pull request as ready for review June 27, 2023 12:43
@flescio flescio requested a review from a team as a code owner June 27, 2023 12:43
@flescio flescio requested review from alfogrillo and removed request for a team June 27, 2023 12:43
@flescio flescio enabled auto-merge (squash) June 27, 2023 12:43
@flescio flescio disabled auto-merge June 27, 2023 12:51
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@flescio flescio force-pushed the flescio/send_static_location branch from 28d09d6 to e804fd4 Compare June 28, 2023 08:59
@flescio flescio force-pushed the flescio/send_static_location branch from 66583b6 to 8eecd40 Compare June 28, 2023 09:22
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flescio flescio enabled auto-merge (squash) June 28, 2023 09:23
@flescio flescio merged commit 102e6a6 into develop Jun 28, 2023
@flescio flescio deleted the flescio/send_static_location branch June 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send current location
2 participants