-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send pin-drop location #1179
Send pin-drop location #1179
Conversation
0180bf7
to
21c7763
Compare
Generated by 🚫 Danger Swift against 8eecd40 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1179 +/- ##
===========================================
- Coverage 41.95% 41.71% -0.24%
===========================================
Files 403 407 +4
Lines 25522 25954 +432
Branches 13305 13448 +143
===========================================
+ Hits 10708 10827 +119
- Misses 14518 14834 +316
+ Partials 296 293 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ElementX/Resources/Assets.xcassets/Images/Location/location-pin.imageset/Contents.json
Outdated
Show resolved
Hide resolved
ElementX/Resources/Assets.xcassets/Images/Location/location-pin.imageset/Location.pdf
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/LocationSharingScreenModels.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/View/StaticLocationScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/RoomAttachmentPicker.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
28d09d6
to
e804fd4
Compare
66583b6
to
8eecd40
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
fixes #1116
Open send static location flow.
Just for a pin location without permissions or user's current location.
The location is sended in RoomFlowCoordinator.