Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static map component #1115

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Static map component #1115

merged 5 commits into from
Jun 20, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented Jun 20, 2023

fixes #1014

Add static map url builder and static map UI component with placeholder and reload logic

@flescio flescio linked an issue Jun 20, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 7e8bd61

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 1.90% and project coverage change: -0.19 ⚠️

Comparison is base (3bbc16f) 43.11% compared to head (16c60ae) 42.93%.

❗ Current head 16c60ae differs from pull request most recent head 7e8bd61. Consider uploading reports for the commit 7e8bd61 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1115      +/-   ##
===========================================
- Coverage    43.11%   42.93%   -0.19%     
===========================================
  Files          385      387       +2     
  Lines        24316    24416     +100     
  Branches     12789    12840      +51     
===========================================
- Hits         10484    10482       -2     
- Misses       13552    13654     +102     
  Partials       280      280              
Flag Coverage Δ
unittests 23.86% <1.90%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Sources/Other/MapLibre/MapLibreStaticMapView.swift 0.00% <0.00%> (ø)
...ntX/Sources/Other/MapLibre/MapTilerStaticMap.swift 0.00% <0.00%> (ø)
.../Sources/Other/MapLibre/MapTilerStyleBuilder.swift 0.00% <0.00%> (ø)
ElementX/Sources/Application/AppSettings.swift 96.72% <100.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flescio flescio marked this pull request as ready for review June 20, 2023 09:59
@flescio flescio requested a review from a team as a code owner June 20, 2023 09:59
@flescio flescio requested review from stefanceriu and removed request for a team June 20, 2023 09:59
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flescio flescio enabled auto-merge (squash) June 20, 2023 10:25
@flescio flescio merged commit 2f091cf into develop Jun 20, 2023
@flescio flescio deleted the flescio/static-map branch June 20, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add static map image from Maptiler
2 participants