Enable noImplicitAny for matrix-js-sdk and matrix-react-sdk

[novocaine]

Your use case

https://www.typescriptlang.org/tsconfig#noImplicitAny

This will mitigate errors at runtime caused by incorrect types being passed.

Have you considered any alternatives?

No response

Additional context

No response

[t3chguy]

js-sdk now has strict mode enabled, which includes noImplicitAny

[t3chguy]

Found 59 errors in 34 files. to go

[Johennes]

@t3chguy is the plan for you to fix all of these yourself as part of this issue?

[t3chguy]

@Johennes yes

[Johennes]

Ouch, that seems like a lot then? 😬

I wonder if there's a reasonable way to split this up across multiple people? So that everyone puts in some time rather than just one person having to fight through it alone.

[t3chguy]

Not without stepping on each other's feet and causing merge conflicts, given "fixing" a file often needs fixing the files it depends on too. We have tried to spread the load using the PR CI check to prevent you introducing new regressions but people got too unhappy with it making their PRs take too long so it became non-mandatory.

[Johennes]

Yeah, it does seem better at this point to put in time to fix this with a conscious effort rather than relying on PRs. I'm just a little worried about you having to fix a thousand issues all by yourself. Sounds like that might get quite annoying quickly. 😟

The issue of fixes in one file requiring further fixes in dependent files is tricky though. Could we have people work on their chunks sequentially? With 5 devs, each one could take ~50 files but we'd make sure to only have one person work on their subtask at a time?

[t3chguy]

@Johennes I've easily fixed 5x that already in previous efforts.

With 5 devs, each one could take ~50 files but we'd make sure to only have one person work on their subtask at a time?

We've tried to encourage people onto these tasks previously and rarely did anyone do any. At this point, to get the Q1 web roadmap task back on track, it needs someone to power through them.

[Johennes]

@Johennes I've easily fixed 5x that already in previous efforts.

Ugh. 😳

Ok, well if you're happy to power through them, let's do that. 👍

Just keep in mind that we have 5 people in the immediate team now. So if we wanted to, we could easily organize a team effort here without having to depend on good will.

[t3chguy]

@Johennes if you have ideas on how to task those people with further tsc strict tasks in my absence next week to keep the momentum going then that'd be great to roll

[t3chguy]

Blocked on #21967