Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poll ended event rendering (PSG-1177) #7402

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

alfogrillo
Copy link
Contributor

Description

This PR improves the rendering of the m.poll.end message adding always the sender information.

Before After
b a

@alfogrillo alfogrillo requested review from a team, pixlwave and flescio and removed request for a team March 2, 2023 16:53
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9441f69) 12.15% compared to head (a0dbd97) 12.16%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7402   +/-   ##
========================================
  Coverage    12.15%   12.16%           
========================================
  Files         1643     1643           
  Lines       162310   162313    +3     
  Branches     66647    66648    +1     
========================================
+ Hits         19728    19738   +10     
+ Misses      141937   141930    -7     
  Partials       645      645           
Flag Coverage Δ
uitests 55.31% <ø> (-0.03%) ⬇️
unittests 6.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/CellData/RoomBubbleCellData.m 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...tartLocationSharing/View/LocationSharingView.swift 57.51% <0.00%> (+0.65%) ⬆️
...tartLocationSharing/LocationSharingViewModel.swift 9.27% <0.00%> (+0.66%) ⬆️
...haringViewer/LiveLocationSharingViewerModels.swift 13.33% <0.00%> (+6.66%) ⬆️
...nSharing/MapView/View/LocationSharingMapView.swift 56.63% <0.00%> (+7.96%) ⬆️
...ionSharingViewer/StaticLocationViewingModels.swift 33.33% <0.00%> (+16.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 47d50d7 into develop Mar 3, 2023
@alfogrillo alfogrillo deleted the alfogrillo/fix_poll_bubbles branch March 3, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants