Automatic poll rules sync (PSG-1135) #7335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 11.99% // Head: 12.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7335 +/- ##
===========================================
+ Coverage 11.99% 12.09% +0.09%
===========================================
Files 1630 1637 +7
Lines 161492 161830 +338
Branches 66249 66429 +180
===========================================
+ Hits 19377 19566 +189
- Misses 141471 141618 +147
- Partials 644 646 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alfogrillo
force-pushed
the
alfogrillo/automatic_poll_rules_sync
branch
from
e68c071
to
a2b1177
Compare
alfogrillo
force-pushed
the
alfogrillo/automatic_poll_rules_sync
branch
from
1c4f000
to
6c25dca
Compare
stefanceriu
approved these changes
Feb 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic to update poll push rules when don't match the ones of normal messages (see the table below).
The check is triggered the first time the matrix session is ready and when the app enters the foreground.
Result