Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh notification service on crypto change #7332

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Feb 2, 2023

CryptoSDK labs flag can be enabled after the notification service has been setup so we need to make sure that background sync service (which internally creates crypto module) is refreshed accordingly

@Anderas Anderas requested review from a team and stefanceriu and removed request for a team February 2, 2023 10:15
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 11.99% // Head: 12.03% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (ca77f36) compared to base (223224c).
Patch coverage: 34.67% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7332      +/-   ##
===========================================
+ Coverage    11.99%   12.03%   +0.03%     
===========================================
  Files         1630     1635       +5     
  Lines       161492   161738     +246     
  Branches     66249    66388     +139     
===========================================
+ Hits         19377    19460      +83     
- Misses      141471   141634     +163     
  Partials       644      644              
Flag Coverage Δ
uitests 55.38% <57.22%> (+0.01%) ⬆️
unittests 5.91% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
...ot/Modules/Room/RoomInfo/RoomInfoCoordinator.swift 0.00% <0.00%> (ø)
.../RoomInfo/RoomInfoCoordinatorBridgePresenter.swift 0.00% <0.00%> (ø)
...Info/RoomInfoList/RoomInfoListViewController.swift 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
.../Spaces/SpaceRoomList/ExploreRoomCoordinator.swift 0.00% <0.00%> (ø)
...llHistory/Coordinator/PollHistoryCoordinator.swift 0.00% <0.00%> (ø)
...ail/Coordinator/PollHistoryDetailCoordinator.swift 0.00% <0.00%> (ø)
...I/Modules/Room/PollHistory/PollHistoryModels.swift 100.00% <ø> (ø)
...linePoll/Coordinator/TimelinePollCoordinator.swift 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit f339757 into develop Feb 2, 2023
@Anderas Anderas deleted the andy/refresh_notifications branch February 2, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants