-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset Crypto SDK labs on logout #7323
Conversation
2b48182
to
485bc0d
Compare
485bc0d
to
02a3fc0
Compare
02a3fc0
to
ff6fab7
Compare
Codecov ReportBase: 12.02% // Head: 12.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #7323 +/- ##
========================================
Coverage 12.02% 12.02%
========================================
Files 1630 1630
Lines 161272 161272
Branches 66073 66073
========================================
Hits 19391 19391
Misses 141237 141237
Partials 644 644
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
We don't really have any mechanism to reset specific user defaults when the user logs out (e.g. all labs flags remain toggled after another user login). That may not be an issue for most settings, but logging out needs to reset crypto SDK setting. To make this a bit more consolidated add
CryptoSDKConfiguration
and disable from legacy app delegate.