Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Crypto SDK labs on logout #7323

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Reset Crypto SDK labs on logout #7323

merged 2 commits into from
Jan 31, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jan 31, 2023

We don't really have any mechanism to reset specific user defaults when the user logs out (e.g. all labs flags remain toggled after another user login). That may not be an issue for most settings, but logging out needs to reset crypto SDK setting. To make this a bit more consolidated add CryptoSDKConfiguration and disable from legacy app delegate.

@Anderas Anderas changed the title Reset Crypto SDK on logout Reset Crypto SDK labs on logout Jan 31, 2023
@Anderas Anderas requested review from a team and aringenbach and removed request for a team January 31, 2023 13:15
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 12.02% // Head: 12.02% // No change to project coverage 👍

Coverage data is based on head (ff6fab7) compared to base (cfe166b).
Patch coverage: 45.76% of modified lines in pull request are covered.

❗ Current head ff6fab7 differs from pull request most recent head 097658f. Consider uploading reports for the commit 097658f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7323   +/-   ##
========================================
  Coverage    12.02%   12.02%           
========================================
  Files         1630     1630           
  Lines       161272   161272           
  Branches     66073    66073           
========================================
  Hits         19391    19391           
  Misses      141237   141237           
  Partials       644      644           
Flag Coverage Δ
uitests 55.64% <83.01%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/CommonConfiguration.swift 87.23% <ø> (ø)
...ot/Categories/MatrixSDKCrypto+LocalizedError.swift 0.00% <0.00%> (ø)
Riot/Modules/Analytics/DecryptionFailure.swift 0.00% <ø> (ø)
Riot/Modules/Analytics/DecryptionFailureTracker.m 35.22% <ø> (ø)
...alytics/Helpers/MXCallHangupReason+Analytics.swift 0.00% <0.00%> (ø)
Riot/Modules/Application/LegacyAppDelegate.m 14.55% <0.00%> (ø)
...KeyBackupRecoverFromPrivateKeyViewController.swift 0.00% <0.00%> (ø)
...eKey/KeyBackupRecoverFromPrivateKeyViewModel.swift 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
Riot/Utils/EventFormatter.m 8.05% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Anderas Anderas merged commit b1a1cb1 into develop Jan 31, 2023
@Anderas Anderas deleted the andy/reset_crypto branch January 31, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants