Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render replies to ended polls (PSG-1131) #7284

Merged
merged 8 commits into from
Jan 19, 2023

Conversation

alfogrillo
Copy link
Contributor

Description

This PR replaces the "Ended poll" placeholder inside replies to m.poll.end events.

The placeholder will be replaced with one of the following in order:

  • The question of the related m.poll.start event
  • The localized version of "Ended poll"

Dependency

matrix-org/matrix-ios-sdk#1685

Result

@alfogrillo alfogrillo requested review from a team and gileluard and removed request for a team January 18, 2023 16:27
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 11.97% // Head: 11.97% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0df3c31) compared to base (be2e153).
Patch coverage: 9.09% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7284      +/-   ##
===========================================
- Coverage    11.97%   11.97%   -0.01%     
===========================================
  Files         1633     1634       +1     
  Lines       160923   161007      +84     
  Branches     65809    65851      +42     
===========================================
+ Hits         19275    19283       +8     
- Misses      141008   141083      +75     
- Partials       640      641       +1     
Flag Coverage Δ
uitests 55.34% <ø> (-0.07%) ⬇️
unittests 5.95% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Models/Room/MXKSendReplyEventStringLocalizer.swift 0.00% <0.00%> (ø)
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 17.10% <12.12%> (-0.09%) ⬇️
Riot/Modules/Application/AppCoordinator.swift 43.80% <0.00%> (-1.20%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...castRecorder/VoiceBroadcastRecorderViewModel.swift 0.00% <0.00%> (ø)
...layback/View/VoiceBroadcastPlaybackErrorView.swift 0.00% <0.00%> (ø)
...r/Coordinator/VoiceBroadcastRecorderProvider.swift 0.00% <0.00%> (ø)
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit fdf1839 into develop Jan 19, 2023
@alfogrillo alfogrillo deleted the alfogrillo/reply_to_ended_polls branch January 19, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants