Change display name fallback for sessions

[alfogrillo]

Description

This PR changes the fallback for sessions' names to the session id instead of the session's device type.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Base: 11.82% // Head: 11.84% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8de1d2a) compared to base (c4d66d6).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7214      +/-   ##
===========================================
+ Coverage    11.82%   11.84%   +0.01%     
===========================================
  Files         1629     1629              
  Lines       160207   160156      -51     
  Branches     65400    65379      -21     
===========================================
+ Hits         18945    18964      +19     
+ Misses      140621   140555      -66     
+ Partials       641      637       -4     

Flag	Coverage Δ
uitests	54.84% <75.00%> (+0.04%)	⬆️
unittests	5.96% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...UserSessions/Common/UserSessionNameFormatter.swift	66.66% <50.00%> (ø)
...Sessions/Common/View/UserSessionCardViewData.swift	87.17% <100.00%> (ø)
...view/View/UserSessionListItemViewDataFactory.swift	92.53% <100.00%> (ø)
...ingViewer/LiveLocationSharingViewerViewModel.swift	52.63% <0.00%> (-1.76%)	⬇️
...herSessions/View/UserOtherSessionsHeaderView.swift	52.83% <0.00%> (+0.10%)	⬆️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift	95.65% <0.00%> (+0.30%)	⬆️
...rOtherSessions/View/UserOtherSessionsToolbar.swift	89.74% <0.00%> (+1.28%)	⬆️
...UserSessionOverview/View/UserSessionOverview.swift	75.00% <0.00%> (+1.96%)	⬆️
Riot/Categories/String.swift	80.00% <0.00%> (+3.33%)	⬆️
...erSessionsOverview/View/UserSessionsOverview.swift	77.94% <0.00%> (+3.92%)	⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[stefanceriu]

lgtm 👍