VoiceBroadcast: Manage app crash cases when recording #7188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 11.82% // Head: 11.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7188 +/- ##
===========================================
+ Coverage 11.82% 11.84% +0.01%
===========================================
Files 1628 1629 +1
Lines 159992 160141 +149
Branches 65224 65373 +149
===========================================
+ Hits 18924 18961 +37
- Misses 140430 140543 +113
+ Partials 638 637 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
giomfo
reviewed
Dec 20, 2022
giomfo
reviewed
Dec 20, 2022
yostyle
reviewed
Dec 21, 2022
giomfo
reviewed
Dec 22, 2022
…he breadcrumbs rooms list By considering potential performance issues, we decided to limit the uncompleted VB cleaning in the recents list service: - we run the process only once when the application is resumed - we run the process only on the breadcrumbs rooms list This prevent us from checking several times in parallel the same room (because a room may be listed in several recents sections) This prevent us from checking several times the same room (each room should be checked only once after the app resume) If a room is not checked from the recents list, a sanity check is still done in RoomViewController (to clean the room when the user opens it)
yostyle
reviewed
Dec 23, 2022
Co-authored-by: Yoan Pintas <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
yostyle
approved these changes
Dec 23, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manage cases when the user is recording and the app crash.