Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceBroadcast: Update live badge layout for recorder and player cells #7178

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 16, 2022

Update live badge layout for recorder and player Voice Broadcast cells

@phloux phloux marked this pull request as ready for review December 16, 2022 15:44
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 11.83% // Head: 11.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (96fd716) compared to base (2a80735).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7178   +/-   ##
========================================
  Coverage    11.83%   11.83%           
========================================
  Files         1628     1628           
  Lines       159946   159951    +5     
  Branches     65179    65196   +17     
========================================
+ Hits         18924    18925    +1     
- Misses      140384   140387    +3     
- Partials       638      639    +1     
Flag Coverage Δ
uitests 54.73% <0.00%> (-0.01%) ⬇️
unittests 5.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 91.30% <0.00%> (-4.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@phloux phloux merged commit 710b09e into develop Dec 19, 2022
@phloux phloux deleted the phlpro/voice_broadcast_live_buttons_layout branch December 19, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants