Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix : Crash on new voice broadcast if the room has avatar #7173

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

giomfo
Copy link
Member

@giomfo giomfo commented Dec 15, 2022

No description provided.

@giomfo giomfo changed the title Bug Fix : Crash if the room has avatar and voice broadcast tiles Bug Fix : Crash on new voice broadcast if the room has avatar Dec 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 11.73% // Head: 11.83% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (60834e1) compared to base (9c13411).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7173      +/-   ##
===========================================
+ Coverage    11.73%   11.83%   +0.10%     
===========================================
  Files         1627     1627              
  Lines       159892   159878      -14     
  Branches     65167    65159       -8     
===========================================
+ Hits         18756    18924     +168     
+ Misses      140492   140316     -176     
+ Partials       644      638       -6     
Flag Coverage Δ
uitests 54.86% <ø> (+0.19%) ⬆️
unittests 5.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 84.31% <0.00%> (-5.89%) ⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 80.39% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
.../Modules/Common/Util/BorderedInputFieldStyle.swift 51.11% <0.00%> (+3.33%) ⬆️
...dules/Common/Util/SecondaryActionButtonStyle.swift 33.33% <0.00%> (+4.44%) ⬆️
...es/Room/Composer/ViewModel/ComposerViewModel.swift 31.37% <0.00%> (+5.44%) ⬆️
...List/MockComposerCreateActionListScreenState.swift 100.00% <0.00%> (+18.51%) ⬆️
...I/Modules/Room/Composer/Model/ComposerModels.swift 75.00% <0.00%> (+19.31%) ⬆️
...Action/ViewModel/ComposerLinkActionViewModel.swift 43.47% <0.00%> (+43.47%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@giomfo giomfo merged commit f61d29f into develop Dec 15, 2022
@giomfo giomfo deleted the giomfo/fix_crash_on_new_vb branch December 15, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants