-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoiceBroadcast: Replace the player timeline #7165
Conversation
Codecov ReportBase: 11.72% // Head: 11.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7165 +/- ##
===========================================
+ Coverage 11.72% 11.83% +0.10%
===========================================
Files 1627 1628 +1
Lines 159850 159945 +95
Branches 65146 65180 +34
===========================================
+ Hits 18740 18924 +184
+ Misses 140466 140383 -83
+ Partials 644 638 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aee4cbc
to
187dc9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a suggestion.
RiotSwiftUI/Modules/Room/VoiceBroadcastPlayback/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eBroadcastPlaybackViewModel.swift Co-authored-by: Yoan Pintas <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Replace the player timeline of Voice Broadcast with the right design.