Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceBroadcast: Replace the player timeline #7165

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 14, 2022

Replace the player timeline of Voice Broadcast with the right design.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 11.72% // Head: 11.83% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (c0ba781) compared to base (34159cb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7165      +/-   ##
===========================================
+ Coverage    11.72%   11.83%   +0.10%     
===========================================
  Files         1627     1628       +1     
  Lines       159850   159945      +95     
  Branches     65146    65180      +34     
===========================================
+ Hits         18740    18924     +184     
+ Misses      140466   140383      -83     
+ Partials       644      638       -6     
Flag Coverage Δ
unittests 5.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...eBroadcastPlayback/View/VoiceBroadcastSlider.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 84.31% <0.00%> (-5.89%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 11.04% <0.00%> (-0.11%) ⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 80.39% <0.00%> (ø)
...eMessages/VoiceMessageAttachmentCacheManager.swift 0.00% <0.00%> (ø)
...MatrixKit/Utils/EventFormatter/HTMLFormatter.swift 72.41% <0.00%> (+2.04%) ⬆️
...w/Service/MatrixSDK/UserSessionsDataProvider.swift 40.29% <0.00%> (+2.46%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from phlpro/voice_broadcast_backward_forward to develop December 14, 2022 16:34
@phloux phloux force-pushed the phlpro/voice_broadcast_player_timeline branch from aee4cbc to 187dc9f Compare December 14, 2022 16:38
@phloux phloux marked this pull request as ready for review December 14, 2022 16:38
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a suggestion.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…eBroadcastPlaybackViewModel.swift

Co-authored-by: Yoan Pintas <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phloux phloux merged commit 8366c96 into develop Dec 15, 2022
@phloux phloux deleted the phlpro/voice_broadcast_player_timeline branch December 15, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants