Download device keys for self prior to verification checks

[hughns]

This PR resolves the equivalent of element-hq/element-android#7676 but for iOS.

There is a race in the current QR implementation around device keys.

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Accessibility has been taken into account.

• Pull request is based on the develop branch

• Pull request contains a changelog file in ./changelog.d
• You've made a self review of your PR
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

Signed-off-by: Hugh Nimmo-Smith [email protected]

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Base: 11.74% // Head: 11.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cc7ff36) compared to base (1efa7c1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7142   +/-   ##
========================================
  Coverage    11.74%   11.75%           
========================================
  Files         1621     1621           
  Lines       159428   159443   +15     
  Branches     64922    64929    +7     
========================================
+ Hits         18732    18735    +3     
- Misses      140058   140070   +12     
  Partials       638      638           

Flag	Coverage Δ
unittests	5.98% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ogin/Common/Service/MatrixSDK/QRLoginService.swift	7.28% <0.00%> (-0.27%)	⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift	95.65% <0.00%> (+0.30%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[stefanceriu]

Looks more than resonable to me 👍