VoiceBroadcast: Be able to pause the playback when it is buffering #7125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giomfo
reviewed
Nov 29, 2022
RiotSwiftUI/Modules/Room/VoiceBroadcastPlayback/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 11.73% // Head: 11.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7125 +/- ##
===========================================
+ Coverage 11.73% 11.77% +0.03%
===========================================
Files 1620 1620
Lines 159288 159341 +53
Branches 64811 64835 +24
===========================================
+ Hits 18687 18755 +68
+ Misses 139957 139948 -9
+ Partials 644 638 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yostyle
approved these changes
Nov 30, 2022
RiotSwiftUI/Modules/Room/VoiceBroadcastPlayback/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift
Show resolved
Hide resolved
yostyle
approved these changes
Nov 30, 2022
RiotSwiftUI/Modules/Room/VoiceBroadcastPlayback/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be able to pause the playback when it is buffering.
Update on the player mechanism.