Do not retry initial sync on fatal errors #7115

Anderas · 2022-11-29T10:14:27Z

If we encounter fatal error during initial sync (defined as a list of error domains), do not attempt another sync as this will not resolve the issue

codecov · 2022-11-29T10:58:45Z

Codecov Report

Base: 11.73% // Head: 11.75% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (df31c30) compared to base (17b45aa).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7115      +/-   ##
===========================================
+ Coverage    11.73%   11.75%   +0.02%     
===========================================
  Files         1620     1621       +1     
  Lines       159271   159475     +204     
  Branches     64804    64939     +135     
===========================================
+ Hits         18687    18752      +65     
- Misses      139940   140073     +133     
- Partials       644      650       +6

Flag	Coverage Δ
unittests	`5.98% <0.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m	`11.15% <0.00%> (-0.06%)`	⬇️
...eateActionList/View/ComposerCreateActionList.swift	`78.35% <0.00%> (-9.01%)`	⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift	`78.92% <0.00%> (-7.18%)`	⬇️
...ionList/Model/ComposerCreateActionListModels.swift	`93.22% <0.00%> (-6.78%)`	⬇️
...List/MockComposerCreateActionListScreenState.swift	`95.45% <0.00%> (-4.55%)`	⬇️
...rdinator/AuthenticationSoftLogoutCoordinator.swift	`6.52% <0.00%> (-0.05%)`	⬇️
...inator/AuthenticationRegistrationCoordinator.swift	`3.84% <0.00%> (-0.02%)`	⬇️
...n/Coordinator/AuthenticationLoginCoordinator.swift	`3.84% <0.00%> (-0.02%)`	⬇️
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m	`13.06% <0.00%> (-0.02%)`	⬇️
Riot/Modules/Room/RoomViewController.swift	`0.00% <0.00%> (ø)`
... and 21 more