Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the left time in the Voice Broadcast tile recorder #7103

Merged
merged 7 commits into from
Nov 25, 2022
Merged

Add the left time in the Voice Broadcast tile recorder #7103

merged 7 commits into from
Nov 25, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Nov 23, 2022

Add the left time in the Voice Broadcast tile recorder.

@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Base: 11.74% // Head: 11.73% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7d155c8) compared to base (62980be).
Patch coverage: 3.46% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7103      +/-   ##
===========================================
- Coverage    11.74%   11.73%   -0.01%     
===========================================
  Files         1620     1620              
  Lines       158933   159255     +322     
  Branches     64621    64789     +168     
===========================================
+ Hits         18666    18689      +23     
- Misses      139630   139930     +300     
+ Partials       637      636       -1
Flag Coverage Δ
uitests 54.80% <23.25%> (-0.10%) ⬇️
unittests 5.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
...imelineCells/SizableCell/SizableBaseRoomCell.swift 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...stRecorder/VoiceBroadcastRecorderScreenState.swift 0.00% <0.00%> (ø)
...castRecorder/VoiceBroadcastRecorderViewModel.swift 0.00% <0.00%> (ø)
...es/Room/Composer/ViewModel/ComposerViewModel.swift 29.78% <57.14%> (-10.22%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phloux phloux force-pushed the phlpro/voicebroadcast_left_time branch from c5ac0ce to 61073ed Compare November 23, 2022 14:00
@phloux phloux marked this pull request as ready for review November 23, 2022 14:12
@phloux phloux requested a review from yostyle November 23, 2022 14:12
giomfo
giomfo approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I have a UX requirement:
is it possible to check the icon alignement, the chrono is not centred with the speaker
image

@phloux
Copy link
Contributor Author

phloux commented Nov 24, 2022

Approved, but I have a UX requirement:
is it possible to check the icon alignement, the chrono is not centred with the speaker
image

Fixed in last commit.

Merge pull request #7105 from vector-im/phlpro/voicebroadcast_fix_scr…
7d155c8 
…oll_issue

Fix scroll issues with VoiceBroadcast and Poll cells
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phloux phloux merged commit 11e39db into develop Nov 25, 2022
@phloux phloux deleted the phlpro/voicebroadcast_left_time branch November 25, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@yostyle yostyle Awaiting requested review from yostyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phloux @giomfo