Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash command to manually discard outbound session #6668

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Sep 5, 2022

This is equivalent to the /discardsession command used in the web client

@Anderas Anderas requested a review from a team September 5, 2022 07:37
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ezPPeG

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@codecov-commenter
Copy link

Codecov Report

Merging #6668 (9b0b579) into develop (b0dd477) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6668      +/-   ##
===========================================
- Coverage     6.26%    6.21%   -0.06%     
===========================================
  Files         1475     1475              
  Lines       155168   155177       +9     
  Branches     62265    62264       -1     
===========================================
- Hits          9718     9639      -79     
- Misses      145045   145135      +90     
+ Partials       405      403       -2     
Impacted Files Coverage Δ
Riot/Modules/Room/MXKRoomViewController.m 0.00% <0.00%> (ø)
Config/CommonConfiguration.swift 85.71% <0.00%> (-5.20%) ⬇️
Riot/Managers/Call/CallPresenter.swift 1.08% <0.00%> (-5.14%) ⬇️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 35.41% <0.00%> (-4.17%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 17.04% <0.00%> (-1.92%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 13.37% <0.00%> (-0.34%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 88.37% <0.00%> (+4.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anderas Anderas merged commit 1a45793 into develop Sep 5, 2022
@Anderas Anderas deleted the andy/discard_session branch September 5, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants