-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings screens items alignment #6311
Fix settings screens items alignment #6311
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
Codecov Report
@@ Coverage Diff @@
## develop #6311 +/- ##
===========================================
- Coverage 6.23% 6.23% -0.01%
===========================================
Files 1440 1440
Lines 155383 155385 +2
Branches 62528 62528
===========================================
- Hits 9684 9681 -3
- Misses 145296 145301 +5
Partials 403 403
Continue to review full report at Codecov.
|
Fixes alignment issues inside all settings screen.
iOS has some inconsistencies on what is returned by separatorInset property of a cell. This uses the tableView separatorInset instead, to make sure that everything is always perfectly aligned.
Also it sets MXKTableViewCellWithLabelAndTextField's label to be left aligned instead of center since it could break alignment in some cases.