Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labs: Rich Text Editor - Adding a link over a blank selection should create a new link with text #7280

Closed
Velin92 opened this issue Jan 17, 2023 · 0 comments · Fixed by #7281
Closed

Labs: Rich Text Editor - Adding a link over a blank selection should create a new link with text #7280

Velin92 opened this issue Jan 17, 2023 · 0 comments · Fixed by #7281
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Labs

Comments

@Velin92
Copy link
Member

Velin92 commented Jan 17, 2023

Your use case

What would you like to do?

When the user selects blank text (containing only whitespace characters and newlines) and then adds a link, the app should prompt them to create a new link with new text, and replace the blank selection with the hyperlink.

Why would you like to do it?

Creating a link over blank text, right now creates a link that is not visible but tappable, which does not make a lot of sense.

Have you considered any alternatives?

No response

Additional context

No response
@Velin92 Velin92 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 17, 2023
@Velin92 Velin92 added the A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor label Jan 17, 2023
@Velin92 Velin92 mentioned this issue Jan 17, 2023
Merged
@Velin92 Velin92 linked a pull request Jan 17, 2023 that will close this issue
Rich Text Editor: Link Improvements #7281
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rich Text Editor: Link Improvements element-hq/element-ios
1 participant
@Velin92