Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build tools. #6886

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Update build tools. #6886

merged 1 commit into from
Oct 14, 2022

Conversation

pixlwave
Copy link
Member

This PR makes 2 changes:

  • Un-pin versions to update tools on each release.
    • SwiftLint isn't updated regularly, this will help us keep updated but in a more stable way than on EX as running pod install will still give reproducible results.
  • Switch to SwiftFormat as a pod
    • Ensures that it is run for everyone and not skipped if it hasn't been installed.

• Un-pin versions to update tools on each release.
• Switch to SwiftFormat as a pod.
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9JAREP

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 11.79% // Head: 11.79% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ce2dbb1) compared to base (928b5f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6886   +/-   ##
========================================
  Coverage    11.79%   11.79%           
========================================
  Files         1573     1573           
  Lines       156078   156078           
  Branches     63083    63084    +1     
========================================
+ Hits         18404    18414   +10     
+ Misses      137056   137045   -11     
- Partials       618      619    +1     
Impacted Files Coverage Δ
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.61% <0.00%> (+0.38%) ⬆️
.../UserSessionDetails/UserSessionDetailsModels.swift 36.36% <0.00%> (+36.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave merged commit 5e69f76 into develop Oct 14, 2022
@pixlwave pixlwave deleted the doug/unpin-tools branch October 14, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants