Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Presence] the presence info should not be displayed when the feature is not supported server side #6597

Closed
giomfo opened this issue Aug 19, 2022 · 3 comments · Fixed by #7342
Labels
A-Room-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Aug 19, 2022

Your use case

When I connect a matrix.org account in Element-iOS, all the members of a room are displayed offline except the current user (displayed in the first position)
image

This offline information is not relevant

Have you considered any alternatives?

We should be able to know client side if the presence is supported or not on the server side to hide presence information in the UI

How to provide this configuration to the client?

Element-web is using the third option, see enable_presence_by_hs_url key in https://app.element.io/config.json

Additional context

This request should be taken into account at least for element-x-ios

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 19, 2022
@pixlwave
Copy link
Member

@giomfo Would it work for you to do the same thing that the PresenceIndicatorView does and use MXPresenceUnknown as a cue to hide the status? @aringenbach implemented this so can probably provide more context.

@giomfo
Copy link
Member Author

giomfo commented Aug 19, 2022

@giomfo Would it work for you to do the same thing that the PresenceIndicatorView does and use MXPresenceUnknown as a cue to hide the status? @aringenbach implemented this so can probably provide more context.

Yes, this sounds like a good plan.
@aringenbach do you know why it was not already done? is there any blocker?

@aringenbach
Copy link
Contributor

@giomfo Yeah I think the only issue that we could have with this is handling the 'self' user presence, given that we just suppose in Element-iOS that they are online since they are currently using the application. Otherwise using MXPresenceUnknown should work for any other user (currently it's marked as offline: see presenceText in Tools.m).

Sorry for the late response, never got a notification for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants